DESENG-651 Update pr template, contributing guide #2570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NatSquared
approved these changes
Jul 31, 2024
|
|
||
|
|
||
| By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the met-public license (Apache 2.0). | ||
| **User Guide update ticket (if applicable):** |
There was a problem hiding this comment.
thanks for getting rid of that boilerplate! and I like the forward thinking with user guide ticket integration
| - Widespread incorrect syntax use (using snake case for many variables in JS when it's not required) | ||
| - Significant amount of repeition in code that can be condensed without much issue (code isn't DRY) * | ||
| - Unnecessary function calls, overly verbose code * | ||
|
|
||
| ## Style Guide | ||
|
|
||
| - Avoid using CSS directly. Instead, style through Material UI theming or with CSS-in-JS |
CONTRIBUTING.md
Outdated
| ### MET Web | ||
|
|
||
| - Be sure to make use of shared components found under `src/components/common`. Below is a non-exhaustive list of common app components: | ||
| - `PrimaryButton`, `SecondaryButton`, `TertiaryButton`: Buttons that come with built-in MET theming and functionality |
There was a problem hiding this comment.
The preferred way to use these is to import the one <Button> component from components/common and use variant=<"primary"|"secondary"|"tertiary"|undefined>
There was a problem hiding this comment.
Thanks for sharing that knowledge! I'll update
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #: https://citz-gdx.atlassian.net/browse/DESENG-651
Description of changes: